Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linkerd top to use the new Tap APIService #3168

Closed
siggy opened this issue Jul 31, 2019 · 0 comments · Fixed by #3186
Closed

Update linkerd top to use the new Tap APIService #3168

siggy opened this issue Jul 31, 2019 · 0 comments · Fixed by #3186
Assignees
@siggy
Labels
area/cli area/tap

Comments

@siggy
Copy link
Member

siggy commented Jul 31, 2019

Follow up from #3167
@siggy siggy mentioned this issue Jul 31, 2019
Closed
5 tasks
@siggy siggy self-assigned this Aug 1, 2019
siggy added a commit that referenced this issue Aug 2, 2019
@siggy
Update linkerd top to use Tap APIService
eac7c52 
PR #3167 introduced a Tap APIService, and migrated `linkerd tap` to it.

This change migrates `linkerd top` to the new Tap APIService. It also
addresses a `panic: close of closed channel`, where two go routines
could both call `close(done)` on exit.

Fixes #3168

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
siggy added a commit that referenced this issue Aug 2, 2019
@siggy
Update linkerd top to use Tap APIService
e276c4c 
PR #3167 introduced a Tap APIService, and migrated `linkerd tap` to it.

This change migrates `linkerd top` to the new Tap APIService. It also
addresses a `panic: close of closed channel` issue, where two go
routines could both call `close(done)` on exit.

Fixes #3168

Signed-off-by: Andrew Seigner <siggy@buoyant.io>

fix

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
siggy added a commit that referenced this issue Aug 2, 2019
@siggy
Update linkerd top to use Tap APIService
dc05096 
PR #3167 introduced a Tap APIService, and migrated `linkerd tap` to it.

This change migrates `linkerd top` to the new Tap APIService. It also
addresses a `panic: close of closed channel` issue, where two go
routines could both call `close(done)` on exit.

Fixes #3168

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
@siggy siggy mentioned this issue Aug 2, 2019
Merged
siggy added a commit that referenced this issue Aug 2, 2019
@siggy
Update linkerd top to use Tap APIService (#3186)
a185cae 
PR #3167 introduced a Tap APIService, and migrated `linkerd tap` to it.

This change migrates `linkerd top` to the new Tap APIService. It also
addresses a `panic: close of closed channel` issue, where two go
routines could both call `close(done)` on exit.

Fixes #3168

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
cpretzer pushed a commit that referenced this issue Aug 6, 2019
@siggy @cpretzer
Update linkerd top to use Tap APIService (#3186)
b638a43 
PR #3167 introduced a Tap APIService, and migrated `linkerd tap` to it.

This change migrates `linkerd top` to the new Tap APIService. It also
addresses a `panic: close of closed channel` issue, where two go
routines could both call `close(done)` on exit.

Fixes #3168

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@siggy siggy

Labels
area/cli area/tap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update linkerd top to use Tap APIService linkerd/linkerd2
1 participant
@siggy