Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include io error message on http metrics #4364

Closed
adleong opened this issue May 8, 2020 · 2 comments · Fixed by linkerd/linkerd2-proxy#512
Closed

Include io error message on http metrics #4364

adleong opened this issue May 8, 2020 · 2 comments · Fixed by linkerd/linkerd2-proxy#512

Comments

@adleong
Copy link
Member

adleong commented May 8, 2020

When an HTTP request fails due to an io error, the "error" label on the http response metric is "unclassified". This can make it very difficult to determine the cause of requests which fail due to io errors such as the remote closing the connection.

We should propagate the io error message onto the HTTP metrics to make these errors easier to identify and debug.
@adleong adleong mentioned this issue May 8, 2020
Closed
@olix0r
Copy link
Member

olix0r commented May 13, 2020 •
edited
Loading

@adleong Is it sufficient to simply be able to indicate that IO errors occurred? Do the various specific error messages indicate anything meaningful?

olix0r added a commit to linkerd/linkerd2-proxy that referenced this issue May 13, 2020
@olix0r
Add an i/o error label to http metrics
98f2c25 
This change modifies HTTP error-labeling to detect I/O errors
and label them explicitly. Previously all I/O errors were reported as
`unexpected`.

Fixes linkerd/linkerd2#4364
@olix0r olix0r mentioned this issue May 13, 2020
Merged
@olix0r
Copy link
Member

olix0r commented May 13, 2020

linkerd/linkerd2-proxy#512 is a very simple change to add an i/o label to help us spot these issues. My hunch is that this is sufficient for the types of spot checking we need to do. (Actual error codes will continue to be logged).

olix0r added a commit to linkerd/linkerd2-proxy that referenced this issue May 13, 2020
@olix0r
Add an i/o error label to http metrics (#512)
fd5a6aa 
This change modifies HTTP error-labeling to detect I/O errors
and label them explicitly. Previously all I/O errors were reported as
`unexpected`.

Additionally, an `errno` label is included when possible.

Fixes linkerd/linkerd2#4364
olix0r added a commit to linkerd/linkerd2-proxy that referenced this issue May 13, 2020
@olix0r
Add an i/o error label to http metrics (#512)
69486e8 
This change modifies HTTP error-labeling to detect I/O errors
and label them explicitly. Previously all I/O errors were reported as
`unexpected`.

Additionally, an `errno` label is included when possible.

Fixes linkerd/linkerd2#4364
@olix0r olix0r mentioned this issue May 13, 2020
Merged
olix0r added a commit to linkerd/linkerd2-proxy that referenced this issue May 14, 2020
@olix0r
Add an i/o error label to http metrics (#512) (#514)
a0ddda7 
This change modifies HTTP error-labeling to detect I/O errors
and label them explicitly. Previously all I/O errors were reported as
`unexpected`.

Additionally, an `errno` label is included when possible.

Fixes linkerd/linkerd2#4364
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an i/o error label to http metrics linkerd/linkerd2-proxy
2 participants
@olix0r @adleong