Policy controller should index services by clusterIPs #12420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the policy controller service indexer to index services by thier `spec.clusterIPs` instead of `spec.clusterIP`, to account for dual-stack services that hold both an IPv4 and an IPv6 address in `spec.clusterIPs`. This change is fully backwards-compatible. This assists the ongoing effort to support IPv6/dual-stack in linkerd, but doesn't imply full support yet.
olix0r
reviewed
Apr 10, 2024
|
This is guaranteed on Service reads since k8s 1.20
|
adleong
approved these changes
Apr 10, 2024
mateiidavid
approved these changes
Apr 11, 2024
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 24, 2024
This changes the policy controller service indexer to index services by thier `spec.clusterIPs` instead of `spec.clusterIP`, to account for dual-stack services that hold both an IPv4 and an IPv6 address in `spec.clusterIPs`. This change is fully backwards-compatible. This assists the ongoing effort to support IPv6/dual-stack in linkerd, but doesn't imply full support yet. Signed-off-by: Mark S <the@wondersmith.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the policy controller service indexer to index services by their
spec.clusterIPsinstead ofspec.clusterIP, to account for dual-stack services that hold both an IPv4 and an IPv6 address inspec.clusterIPs.This change is fully backwards-compatible.
This assists the ongoing effort to support IPv6/dual-stack in linkerd, but doesn't imply full support yet.