Add port to route status parent ref #12454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <alex@buoyant.io>
olix0r
approved these changes
Apr 18, 2024
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 22, 2024
Signed-off-by: Alex Leong <alex@buoyant.io> Signed-off-by: Mark S <the@wondersmith.dev>
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 22, 2024
Signed-off-by: Alex Leong <alex@buoyant.io> Signed-off-by: Mark S <the@wondersmith.dev>
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 24, 2024
Signed-off-by: Alex Leong <alex@buoyant.io> Signed-off-by: Mark S <the@wondersmith.dev>
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 24, 2024
Signed-off-by: Alex Leong <alex@buoyant.io> Signed-off-by: Mark S <the@wondersmith.dev>
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 24, 2024
Signed-off-by: Alex Leong <alex@buoyant.io> Signed-off-by: Mark S <the@wondersmith.dev>
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 24, 2024
Signed-off-by: Alex Leong <alex@buoyant.io> Signed-off-by: Mark S <the@wondersmith.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
httproutes.policy.linkerd.ioCRD was missing aportfield in the schema for route status parent ref. This field was attempting to be set by the policy controller when setting the status of an HTTPRoute but the absence of this field in the schema meant that the status would never converge. This results is thrashing as the policy controller repeatedly attempts to correct the status.We add this field to all versions of the schema without creating a new resource version because the omission of this field was a bug and adding it is backwards compatible.