feat(cli): Add json output to link, unlink, allow, and allow-scrapes commands #12658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mands Signed-off-by: Alex Leong <alex@buoyant.io>
pkg/k8s/resource/resource.go
Outdated
| @@ -112,6 +113,22 @@ func (r Kubernetes) RenderResource(w io.Writer) error { | |||
| return err | |||
| } | |||
|
|
|||
| // RenderResource renders a kubernetes object as a json object | |||
There was a problem hiding this comment.
Suggested change
| // RenderResource renders a kubernetes object as a json object | |
| // RenderResourceJSON renders a kubernetes object as a json object |
|
Marking as draft until #12641 merges so that we can reuse library functions defined there. |
mateiidavid
reviewed
Jun 12, 2024
Signed-off-by: Alex Leong <alex@buoyant.io>
mateiidavid
approved these changes
Jun 13, 2024
Signed-off-by: Alex Leong <alex@buoyant.io>
olix0r
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add an
-o/--outputflag to the remaining commands which render kubernetes resources and do not yet have this flag. The supported values for this flag are "yaml" (default) and "json". The commands are: