refactor(status): make route types generic #12661
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Prepare to expand
linkerd
's repertoire of supportedGateway API
route types inlinkerd-policy-controller-k8s-status
.Problem
Currently, the policy controller's
status
component is written withHTTPRoute
support (effectively) exclusively, both in its structure/organization as well as its naming (e.g.HttpRoute
as a primary type name,update_http_route
as a method name, etc...).In order to expand
linkerd
's support for the route types defined by the Gateway API, the policy controller'sstatus
component needs to be made more generic in both respects.Solution
PR introduces structural and naming changes making the codebase generic with respect to the type of route being handled (e.g.
HTTPRoute
->Route
). Changes are almost entirely cosmetic introducing only a couple of minor functional changes, most notably:status
argument tomake_patch
genericapi_version
helper method toNamespaceGroupKindName
Validation
FixesLays Groundwork For Addressing