Clarifies documentation on connectAddr (helm chart) #12827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The networkValidator.connectAddr helm chart parameter is ambiguously documented which leads to confusion. This PR amends the documentation to improve comprehension. Fixes #12797 Signed-off-by: Ryan Jacobs <ryan@ryanjjacobs.com>
|
Thanks @djryanj this looks good to me. Can you please run If it's a no-op, let me know. |
With the previous commit, documentation changes were needed to README.md. This commit and subsequent PR has those changes. Fixes #12797 Signed-off-by: Ryan Jacobs <ryan@ryanjjacobs.com>
|
@mateiidavid - ran |
mateiidavid
approved these changes
Jul 15, 2024
|
Awesome, thank you so much @djryanj! Changes look great to me. |
|
Thank you @djryanj ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The networkValidator.connectAddr helm chart parameter is ambiguously documented which leads to confusion.
This PR amends the documentation to improve comprehension.
Fixes #12797