Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes for edge-19.8.2 #3216

Merged
merged 4 commits into from
Aug 8, 2019
Merged

Add changes for edge-19.8.2 #3216

merged 4 commits into from
Aug 8, 2019

Conversation

scottcarol
Copy link
Contributor

No description provided.

@l5d-bot
Copy link
Collaborator

l5d-bot commented Aug 8, 2019

Integration test results for 8d929af: fail 😕
Log output: https://gist.github.com/ed6228bb1fa2f966d1b7317ce3ef35c6

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Copy link
Member

@siggy siggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good. left some comments around making the bullets more user-facing.

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@scottcarol
Copy link
Contributor Author

Just pushed changes, would you mind giving the Controller and CLI changes one more look @siggy @ihcsim?

Copy link
Member

@siggy siggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple more nits then 🚢 👍

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@l5d-bot
Copy link
Collaborator

l5d-bot commented Aug 8, 2019

Integration test results for 9795f6d: success 🎉
Log output: https://gist.github.com/6fc2760eaefa864a91589c1a317dee7a

CHANGES.md Outdated Show resolved Hide resolved
@scottcarol scottcarol merged commit 0267f01 into master Aug 8, 2019
@scottcarol scottcarol deleted the cscott/edge-19.8.2 branch August 8, 2019 22:47
@l5d-bot
Copy link
Collaborator

l5d-bot commented Aug 8, 2019

Integration test results for 6abb1e9: success 🎉
Log output: https://gist.github.com/aa1ec2c3665f466a7e0bfe9ffb161f68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants