Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change square by round brackets in cli usage manual (#3999) #5285

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

jiraguha
Copy link
Contributor

Signed-off-by: jpiraguha jiraguha@gmail.com

Fixes #3999

@jiraguha jiraguha requested a review from a team as a code owner November 26, 2020 03:43
@jiraguha
Copy link
Contributor Author

@olix0r pipeline fails on integration Integration tests (external-issuer) I can tell why... a small help is needed thanks

@olix0r
Copy link
Member

olix0r commented Nov 27, 2020

@jiraguha Thanks for the help fixing this issue!

I'm assuming that test failure is CI flakiness -- rerunning now to confirm.

Copy link
Member

@olix0r olix0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. works.

Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested fine in my Linux machine, as long as I followed the instructions not under "# zsh" but under "# zsh on osx / oh-my-zsh" (also from looking at cobra's docs, I only see the latter method being mentioned) . @jiraguha would you amend the instructions in linkerd completion for zsh so we get rid of the former? Thanks!

...By the way, I think we'll submit this as a plugin to oh-my-zsh to make this work out of the box 😉

Signed-off-by: jpiraguha <jiraguha@gmail.com>
@jiraguha
Copy link
Contributor Author

jiraguha commented Dec 2, 2020

@alpeb we should be good now, I followed the same template as cobra. For oh-my-zsh I can open an issue and a PR's for linkerd so we could collaborate to make it work. I would be happy to take the subject :-)

Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, LGTM 👍

For oh-my-zsh I can open an issue and a PR's for linkerd so we could collaborate to make it work. I would be happy to take the subject :-)

That'd be awesome, thanks!
Are you interested in linkerd swag? Please fill out this form :-)

@alpeb alpeb merged commit ed1dff5 into linkerd:main Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linkerd completion command does not work as expected
3 participants