-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /metrics endpoint server to the proxy #547
Conversation
@@ -166,6 +171,10 @@ where | |||
inbound_listener.local_addr(), | |||
config.private_forward | |||
); | |||
info!( | |||
"serving scrapable metrics on {:?}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/scrapable/prometheus/ ?
@@ -0,0 +1,59 @@ | |||
use std::sync::Arc; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider calling this file prometheus
, since it is specifically going to be in prometheus format, and scrape might be less understandable immediately for Future Us.
This PR adds a Hyper server that serves the proxy
/metrics
endpoint. It currently doesn't serve anything because no scrapable metrics are collected. The metrics server's address and port can be configured with theCONDUIT_PROXY_METRICS_LISTENER
environment variable.Closes #540