Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add default-inbound-policy to inject flags #7428

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

ahmedalhulaibi
Copy link
Contributor

PR #6750 adds the config.linkerd.io/default-inbound-policy annotation for setting the default inbound policy for an injected proxy.

This commit adds support for a default-inbound-policy flag in makeProxyFlags so that it can be set with the linkerd inject command.

Closes #6754

Signed-off-by: ahmedalhulaibi ahmed.alhulaibi41@gmail.com

@ahmedalhulaibi ahmedalhulaibi requested a review from a team as a code owner December 7, 2021 17:49
Copy link
Member

@adleong adleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one question about the test cases.

cli/cmd/inject_test.go Outdated Show resolved Hide resolved
PR linkerd#6750 adds the config.linkerd.io/default-inbound-policy annotation for setting the default inbound policy for an injected proxy.

This commit adds support for a default-inbound-policy flag in makeProxyFlags so that it can be set with the linkerd inject command.

Closes linkerd#6754

Signed-off-by: ahmedalhulaibi <ahmed.alhulaibi41@gmail.com>

tests: use all-authenticated constant
Copy link
Contributor

@kleimkuhler kleimkuhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahmedalhulaibi!

@kleimkuhler kleimkuhler merged commit 9c0d457 into linkerd:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add default-inbound-policy to proxy injection flags
3 participants