Set up helm charts versioning #7448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements part of #7405 Separates `version` from `appVersion` in both `linkerd-crds` and `linkerd-control-plane` charts. In `linkerd-crds` embeds `version` as a label in the CRDs. In `linkerd-control-plane`, embeds `linkerd-crds`'s `version` as a new entry in the `linkerd-config` ConfigMap, to use in a new `linkerd check` that will be implemented in a separate PR.
kleimkuhler
reviewed
Dec 10, 2021
| @@ -16,8 +16,7 @@ dependencies: | |||
| - name: partials | |||
| version: 0.1.0 | |||
| repository: file://../partials | |||
| # this version will be updated by the CI before publishing the Helm tarball | |||
| version: 0.1.0 | |||
| version: 1.0.0-edge | |||
There was a problem hiding this comment.
So do we begin updating this now with the year.month.edge-number now? If not, when is this bumped?
There was a problem hiding this comment.
Unlike appVersion, this has to follow semver's major.minor.patch[-pre-release identifier]. I proposed in #7405 the following bumping criteria:
- patch: bump for minor changes
- minor: bump for new additions in templates or to values.yaml
- major: bump for backwards-incompatible changes made to values.yaml
There was a problem hiding this comment.
Sounds good. So lets say edge-21.12.3 is the first edge with these changes.
The GitHub release and linkerd version output will still be edge-21.12.3, but the Helm version for linkerd-control-plane would be 1.0.1-edge?
There was a problem hiding this comment.
Correct. For linkerd-control-plane, helm will expose both the chart and the app versions:
$ helm ls -A
NAME NAMESPACE REVISION UPDATED STATUS CHART APP VERSION
linkerd-crds linkerd 1 2021-12-10 11:47:32.885183008 -0500 -05 deployed linkerd-crds-1.0.0-edge
linkerd-control-plane linkerd 1 2021-12-10 11:47:59.548941284 -0500 -05 deployed linkerd-control-plane-1.0.0-edge edge-21.12.2
kleimkuhler
reviewed
Dec 10, 2021
kleimkuhler
reviewed
Dec 10, 2021
alpeb
force-pushed
the
alpeb/helm-versioning
branch
from
dc6d78b to
7d8daa5
Compare
kleimkuhler
approved these changes
Dec 10, 2021
adleong
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements part of #7405
Separates
versionfromappVersionin bothlinkerd-crdsandlinkerd-control-planecharts.In
linkerd-crdsembedsversionas a label in the CRDs.In
linkerd-control-plane, embedslinkerd-crds'sversionas a newentry in the
linkerd-configConfigMap, to use in a newlinkerd checkthat will be implemented in a separate PR.