Bind this.handleApiError in PodDetail #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadjeibaah
approved these changes
Dec 22, 2017
franziskagoltz
approved these changes
Dec 22, 2017
| @@ -17,9 +17,9 @@ export default class Deployments extends React.Component { | |||
| constructor(props) { | |||
| super(props); | |||
| this.api = ApiHelpers(this.props.pathPrefix); | |||
| this.handleApiError = this.handleApiError.bind(this); | |||
There was a problem hiding this comment.
nice alphabetizing 🔤
pcalcado
pushed a commit
that referenced
this pull request
Dec 27, 2017
pcalcado
pushed a commit
that referenced
this pull request
Dec 27, 2017
khappucino
pushed a commit
to Nordstrom/linkerd2
that referenced
this pull request
Mar 5, 2019
The `metrics!` macro is currently local to the telemetry module. Furthermore, the `telemetry::metrics` module no longer has proxy-specific logic. This change moves the `telemetry::metrics` module into a new crate, `linkerd2_metrics`. This will enable unifying `telemetry::http` and `telemetry::transport` into `http` and `transport`, respectively.
khappucino
pushed a commit
to Nordstrom/linkerd2
that referenced
this pull request
Mar 5, 2019
Following linkerd#84, the `telemetry::transport` module can be moved into the `transport` module. This should allow us to simplify type signatures by combining redundant types. It's also hoped that we can reduce the API boilerplate around metrics so it's much easier to instrument and track new metrics in transport code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #65 I forgot to bind handleApiError in the PodDetail module, which resulted in this error if a fetch call failed:
This adds that binding.