Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect reference to non-existent linkerd-base chart in docs #1491

Closed
philomory opened this issue Sep 11, 2022 · 0 comments · Fixed by #1492
Closed

Incorrect reference to non-existent linkerd-base chart in docs #1491

philomory opened this issue Sep 11, 2022 · 0 comments · Fixed by #1492

Comments

@philomory
Copy link
Contributor

philomory commented Sep 11, 2022

In the docs for automatically rotating control-plane tls credentials, in the section on installing with Helm, the following statement is written:

Installing with Helm
For installing with Helm, first install the linkerd-crds and linkerd-base charts:

helm install linkerd-base -n linkerd linkerd/linkerd-crds
helm install linkerd-base -n linkerd --create-namespace linkerd/linkerd-base

There's three problems here: first, the first command uses the linkerd namespace before the second command creates it; second, the linkerd-base chart doesn't actually seem to exist; and third, even if it did, this is instructing the user to install two different charts into the same namespace under the same release name (which is impossible).

As I understand it, the chart that is now called linkerd-crds was at one time going to be called linkerd-base, and someone got a bit muddled when updating the docs.

philomory added a commit to philomory/website that referenced this issue Sep 11, 2022
`linkerd-base` chart doesn't exist.
philomory added a commit to philomory/website that referenced this issue Sep 11, 2022
`linkerd-base` chart doesn't exist.

Signed-off-by: Adam Gardner <adam.gardner@magicmemories.com>
philomory added a commit to philomory/website that referenced this issue Sep 12, 2022
`linkerd-base` chart doesn't exist.

Signed-off-by: Adam Gardner <adam.gardner@magicmemories.com>
alpeb added a commit that referenced this issue Sep 12, 2022
* Fix #1491

`linkerd-base` chart doesn't exist.

Signed-off-by: Adam Gardner <adam.gardner@magicmemories.com>

* Update linkerd.io/content/2.12/tasks/automatically-rotating-control-plane-tls-credentials.md

Co-authored-by: Alejandro Pedraza <alejandro.pedraza@gmail.com>
Signed-off-by: Adam Gardner <adam.gardner@magicmemories.com>

Signed-off-by: Adam Gardner <adam.gardner@magicmemories.com>
Co-authored-by: Alejandro Pedraza <alejandro.pedraza@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant