deleteScript can now be a callback

[derrekbertrand]

Not that anyone asked for it to my knowledge, but this is a handy option that I'm using on my server.

The signature of Image.deleteFile changed to take the jQuery element, instead of src. It now checks if your deleteScript option is a function, and if so passes the element to the callback allowing the end developer to get whatever info they need from the element and make their own AJAX call, if they desire.

The other delete options are ignored in this case, and it is up to the end developer to handle their AJAX options.

---

Use case: I'm using an API to handle my images that requires making a request like DELETE /api/v1/image/42, where 42 is the image's unique id. This is very difficult to do under the current structure. This modification allows you tons of freedom when deleting. If you want to use the old behavior, your code need not change.

I have never worked on a JS project, please be gentle.

[linkesch]

@derrekbertrand thanks. Good idea. I left you just one comment regarding backwards compatibility. After that's done, we can merge this.

[derrekbertrand]

@orthes Where's the comment? I checked my branch's commit, and I don't see anything.

[linkesch]

@derrekbertrand it's here in the pull request.

Can you make Images.prototype.deleteFile function backward compatible for people using the current implementation? For example leave the first attribute as it was before (string) and add $file as a second attribute. And pass both also to deleteScript function for consistency.

[derrekbertrand]

Definitely. I'll do that Monday, and I'll update the docs too.

…

On Jun 3, 2017 6:49 AM, "Pavel Linkesch" ***@***.***> wrote: @derrekbertrand <https://github.com/derrekbertrand> it's here in the pull request. Can you make Images.prototype.deleteFile function backward compatible for people using the current implementation? For example leave the first attribute as it was before (string) and add $file as a second attribute. And pass both also to deleteScript function for consistency. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#428 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA7GPIpZ5QlwJVGQ0iSb7Rv2pLZo1DqHks5sATo7gaJpZM4NudhB> .

[derrekbertrand]

@orthes I believe this will do it. I'll see if I can find some docs to update.

EDIT:
I will make a similar edit to the upload script if it would be accepted. I'm using this API standard, btw.
Also, do I just edit the Wiki for docs?

EDIT2:
It looks like upload is plenty robust.