This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
Use object url for image previews #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkesch
approved these changes
Jan 24, 2019
|
Thanks for the test. Changes are in the latest commit. I hope it's not too messy with multiple commits. |
|
thanks |
|
@all-contributors please add @keligijus for code |
|
I've put up a pull request to add @keligijus! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using FileReader for previews slows down the editor because it's using base64 encoded file. Object URL has better performance, the editor is no longer laggy or freezing while an image is being uploaded.
Please note, that I wasn't able to fix the broken test. If it's possible I would highly appreciate some guidance from the maintainers on fixing the test.