Flesh out transformation tests #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amending examples to include other relationship types Regenerate agent model
ialarmedalien
commented
Apr 17, 2023
| @@ -119,7 +119,6 @@ classes: | |||
| ProcedureConcept: | |||
| is_a: Concept | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
my IDE trims whitespace
ialarmedalien
commented
Apr 17, 2023
Comment on lines
+7
to
+11
| from linkml_runtime.linkml_model import ( | ||
| ClassDefinition, | ||
| SlotDefinition, | ||
| SchemaDefinition, | ||
| ) |
There was a problem hiding this comment.
I ran black over the file after saving so the formatting would be consistent, hence there are some layout diffs
ialarmedalien
commented
Apr 17, 2023
| print(yaml.dump(target_obj)) | ||
| self.assertEqual(AGE_STRING, target_obj["age"]) | ||
|
|
||
| def check_familial_relationships(self, obj, data_model, expected): |
There was a problem hiding this comment.
pull out common tests
ialarmedalien
commented
Apr 17, 2023
Comment on lines
+178
to
+181
| self.assertEqual("U:1", mset.mappings[0].subject) | ||
| self.assertEqual("Y:1", mset.mappings[0].object.id) | ||
| self.assertEqual("y1", mset.mappings[0].object.name) | ||
| self.assertEqual("P:1", mset.mappings[0].predicate) |
There was a problem hiding this comment.
replace print statements with tests
ialarmedalien
commented
Apr 17, 2023
Comment on lines
+233
to
+242
| self.assertEqual( | ||
| target_obj["mappings"][0], | ||
| { | ||
| "subject_id": "X:1", | ||
| "subject_name": "x1", | ||
| "object_id": "Y:1", | ||
| "object_name": "y1", | ||
| "predicate_id": "P:1", | ||
| }, | ||
| ) |
There was a problem hiding this comment.
flesh out tests again
ialarmedalien
commented
Apr 17, 2023
| @@ -7,7 +7,8 @@ | |||
| from tests import EXAMPLE_DIR | |||
|
|
|||
| EXAMPLES = [ | |||
| ("measurements", "quantity_value", "qv-to-scalar", "PersonQuantityValue-001", None), | |||
| ("measurements", "quantity_value", "qv-to-scalar", "PersonQuantityValue-001", 172.0), | |||
| ("measurements", "quantity_value", "qv-to-scalar", "PersonQuantityValue-002", None), | |||
There was a problem hiding this comment.
Added an extra file to test both conditions of the transform
|
looks like something is up with flake8 independent of this PR, I'll go ahead and merge for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more checks to test_transformer_examples
Amending examples to include other relationship types
Regenerating agent model