Adding MultiFileTransformer #6
Conversation
|
Did you see that nearly all tests are failing? I'm going to extract out some of the linting/formatting stuff from this PR to reduce its size a bit. |
|
OK I believe using the latest reference validator will fix, we shall see... |
|
are tests passing locally? |
|
OK, it definitely should work now (the tests were previously working locally for me as I had a local copy of changes to linkml-runtime). However, now something is up w.r.t coverage. Not really sure how your PR can be interacting with mine...? |
|
They aren't interacting. This PR is using the old test/coverage command -- it looks like the coverage package isn't being installed so the coverage command is failing. Tests/coverage should work when the other PR is merged and then this one rebased/merged. |
| {%- elif sd.expr -%} | ||
| {{ sd.expr }} |
There was a problem hiding this comment.
this generates invalid code ATM -- need to replace {var_name} with var_name
e.g.
def derive_Agent(
source_object: src.Person
) -> tgt.Agent:
return Person(
id=source_object.id,
label=source_object.name,
age=str({age_in_years})+' years',
...
)There was a problem hiding this comment.
yes - the compiler subpackages should come with big health warnings for now, this is more an exploration of what can be done
| @@ -40,6 +40,9 @@ classes: | |||
| description: human readable title for this transformation specification | |||
| prefixes: | |||
| description: maps prefixes to URL expansions | |||
| range: KeyVal | |||
There was a problem hiding this comment.
Not specific to this line of the file, but can/should there be a specification of the language used for expr? I know it's supposed to be in the language agnostic linkml expression syntax (cough python cough), but it would be good to explicitly specify this, so that it is then possible to use other languages for expressing these transformations.
There was a problem hiding this comment.
We should definitely do this! this is now a little easier as we have https://github.com/linkml/semantic-dsl
| @@ -106,3 +144,19 @@ def _coerce_to_singlevalued(self, slot_derivation: SlotDerivation, class_derivat | |||
| if not slot.multivalued: | |||
| return True | |||
| return False | |||
|
|
|||
| @property | |||
| def curie_converter(self) -> Converter: | |||
ah ok. should we wait - not sure how much there is to do on the other PR. I would be open to doing a cheeky merge of this PR and then moving to a more robust approach moving forward |
|
The other PR is done -- it was mostly to reduce the size of this PR by removing some of the black/isort linting changes. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6 +/- ##
=======================================
Coverage ? 86.51%
=======================================
Files ? 20
Lines ? 749
Branches ? 0
=======================================
Hits ? 648
Misses ? 101
Partials ? 0 |
The MFT is analogous to linkml-run-examples, but instead of performing conversion, it will perform a transformations, and check the output against what is expected