Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

Commit

Permalink
Improve validation messages for jsonschema_validation plugin (#4)
Browse files Browse the repository at this point in the history
* Add field and value to error message in jsonschema_validation
* Fix formatting of messages in range_validation
* Update setup.cfg
* Bump version to 0.1.0
  • Loading branch information
deepakunni3 authored Mar 23, 2022
1 parent 5a10b89 commit 27af1f2
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion linkml_validator/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.0.1"
__version__ = "0.1.0"
5 changes: 4 additions & 1 deletion linkml_validator/plugins/jsonschema_validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,13 @@ def process(self, obj: Dict, **kwargs) -> ValidationResult:
)
except jsonschema.ValidationError as error:
msg = error.message
field = ".".join(error.relative_path) if error.relative_path else None
valid = False
msg = ValidationMessage(
severity=SeverityEnum.error.value,
message=msg
message=msg,
field=field,
value=error.instance
)
result = ValidationResult(
plugin_name=self.NAME, valid=valid, validation_messages=[msg]
Expand Down
2 changes: 1 addition & 1 deletion linkml_validator/plugins/range_validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def process(self, obj: Dict, **kwargs) -> ValidationResult: # noqa: C901
message = ValidationMessage(
severity="Error",
message=f"{target_class}.{field}"
+ "must have a value from {permissible_values}",
+ " must have a value from {permissible_values}",
field=field,
value=value
)
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ zip_safe = False
include_package_data = True
packages = find:
install_requires =
pydantic>=1.9.0
pydantic>=1.8.2
linkml>=1.1.18
linkml_runtime>=1.2.0
stringcase>=1.2.0
Expand Down

0 comments on commit 27af1f2

Please sign in to comment.