Skip to content

Commit

Permalink
Bug fixes and minor improvements. (#123)
Browse files Browse the repository at this point in the history
* OI-246 Removed link to content from News title, fixed tags visibility on News page itself and inside the /news. Fixed "User page" condition submit logic.

* OI-206 Changed thumbnail style to compact_user_icon in next user view modes: additional details, default, edit.

* OI-243 Change OpenidealIdeaUpdateInfo create and change date formats. Fix CSS styles for right sidebar of content types canonical pages.

* OI-85 Fix CSS for workflow block, and mobile view of /idea page.

* Reverted composer.json changes.

* OI-243 Removed unneeded code.

* OI-125,142 Changed moderation content view title, and altered local task title. Changed slideshow arrows.

* OI-243,254 Implemented logic to change default format of input html5 date formatter into "dd-mm-yyyy", installed the momentjs library, for it. Changed format field_created description of every node types. Implemented logic to validate minimal value possible to set into schedule open/close.

* OI-254 Implement function to render the default date string. Removed unneeded moment, and reworked code.

* OI-246. Implemented OpenidealRRSSBBlock, which provide ability to set an entity from context e.g. from layout builder. Implemented styles for /news page.

* OI-142 Remove momentjs from .libraries

* OI-246. Removed unneeded code.

* OI-257 Add idea status block to the frontpage teaser view mode. Implemented desktop and mobile styles for the block.

* OI-238 Increase image quality.

* OI-243 Fix the demo content module. Fix mobile view of news page, add ability to show activity feed on button click.

* OI-243 Change content moderation views route path.

* OI-243 Remove ability to set paste date as challenge schedule.

* Upgraded drupal/message to 1.1.

* OI-124 Disable default content_moderation display page, remove all logic related to it inside profile, implemented additional logic, to hide the tab for content moderation if the view display is disabled. Duplicate content_moderation display for Ideas, create link task for it.

Co-authored-by: Nazariy Velychenko <n.velychenko@dev-branch.com>, Zohar Stolar <z.stolar@gmail.com>
  • Loading branch information
db-Matroskeen and zohar authored Oct 2, 2020
1 parent b4395b6 commit 544e1a2
Show file tree
Hide file tree
Showing 46 changed files with 1,629 additions and 192 deletions.
5 changes: 1 addition & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@
"drupal/honeypot": "^2.0",
"drupal/layout_builder_styles": "^1.0@beta",
"drupal/metatag": "^1.13",
"drupal/message": "^1.0",
"drupal/message": "1.1",
"drupal/message_notify": "^1.1",
"drupal/moderation_state_buttons_widget": "^1.0@alpha",
"drupal/multiple_fields_remove_button": "^1.0@alpha",
Expand Down Expand Up @@ -274,9 +274,6 @@
"drupal/rules": {
"ServiceNotFoundException when installing a rule via configuration": "https://www.drupal.org/files/issues/2020-07-10/ServiceNotFoundException-when-installing-a-rule-via-configuration.2870851-10_0.patch"
},
"drupal/message": {
"Message template should depend on text(s) filter formats": "https://www.drupal.org/files/issues/2020-08-03/3163049-2.patch"
},
"drupal/ckeditor_mentions": {
"Use the official CKEditor mention plugin": "https://www.drupal.org/files/issues/2020-09-15/ckeditorplugin-3009308-28.patch"
},
Expand Down
1 change: 1 addition & 0 deletions config/install/block.block.node_tags.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ visibility:
node_type:
id: node_type
bundles:
article: article
idea: idea
negate: false
context_mapping:
Expand Down
2 changes: 1 addition & 1 deletion config/install/block.block.openideal_theme_branding.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ settings:
provider: system
label_display: '0'
use_site_logo: true
use_site_name: true
use_site_name: false
use_site_slogan: false
visibility: { }
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ dependencies:
config:
- views.view.public_activity
module:
- system
- route_condition
- views
theme:
- openideal_theme
Expand All @@ -22,8 +22,8 @@ settings:
views_label: 'Latest updates'
items_per_page: none
visibility:
request_path:
id: request_path
pages: '<front>'
route:
id: route
routes: "view.frontpage.front_page\r\nview.news.all_news_page"
negate: false
context_mapping: { }
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ dependencies:
- field.field.node.article.field_tags
- node.type.article
module:
- content_moderation
- entity_browser
- metatag
- path
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ dependencies:
- node.type.challenge
module:
- allowed_formats
- content_moderation
- entity_browser
- metatag
- openideal_challenge
Expand Down
2 changes: 0 additions & 2 deletions config/install/core.entity_form_display.node.idea.default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,10 @@ dependencies:
- field.field.node.idea.field_meta_tags
- field.field.node.idea.field_overall_score
- node.type.idea
- workflows.workflow.life_cycle_phases
module:
- allowed_formats
- entity_browser
- metatag
- moderation_state_buttons_widget
- path
- text
- votingapi_reaction
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ content:
region: content
settings:
entity_browser: openideal_image_browser
field_widget_remove: true
field_widget_remove: '1'
selection_mode: selection_append
preview_image_style: thumbnail
preview_image_style: compact_user_icon
field_widget_edit: true
field_widget_replace: false
open: false
field_widget_replace: 0
open: 0
view_mode: default
third_party_settings: { }
field_age_group:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ content:
entity_browser: openideal_image_browser
field_widget_remove: '1'
selection_mode: selection_append
preview_image_style: thumbnail
preview_image_style: compact_user_icon
field_widget_edit: true
field_widget_replace: 0
open: 0
Expand Down
2 changes: 1 addition & 1 deletion config/install/core.entity_form_display.user.user.edit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ content:
entity_browser: openideal_image_browser
field_widget_remove: true
selection_mode: selection_append
preview_image_style: thumbnail
preview_image_style: compact_user_icon
field_widget_edit: true
field_widget_replace: false
open: false
Expand Down
33 changes: 31 additions & 2 deletions config/install/core.entity_view_display.node.article.full.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ third_party_settings:
label: hidden
type: string
settings:
link_to_entity: true
link_to_entity: false
third_party_settings: { }
context_mapping:
entity: layout_builder.entity
Expand Down Expand Up @@ -182,7 +182,15 @@ third_party_settings:
context_mapping:
entity: layout_builder.entity
view_mode: view_mode
additional: { }
additional:
visibility:
1cee6ed2-1b92-4998-895e-d075033ef2c7:
id: request_path
pages: /news
negate: 0
uuid: 1cee6ed2-1b92-4998-895e-d075033ef2c7
context_mapping: { }
visibility_operator: and
weight: 5
4bdbe2b4-4a31-41b9-a87a-8b0e2b1f3f0e:
uuid: 4bdbe2b4-4a31-41b9-a87a-8b0e2b1f3f0e
Expand All @@ -198,6 +206,27 @@ third_party_settings:
layout_builder_styles_style:
mobile_status_and_statistics: 0
weight: 6
bfb33572-2f22-43fb-98d8-593359b4b883:
uuid: bfb33572-2f22-43fb-98d8-593359b4b883
region: second
configuration:
id: openideal_rrssb_block
label: Share
provider: openideal_idea
label_display: visible
button_set: default
context_mapping:
node: layout_builder.entity
additional:
visibility:
dc6f33c4-a8e2-413d-986e-3e767288f7a7:
id: request_path
pages: /news
negate: 0
uuid: dc6f33c4-a8e2-413d-986e-3e767288f7a7
context_mapping: { }
visibility_operator: and
weight: 7
third_party_settings: { }
id: node.article.full
targetEntityType: node
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ third_party_settings:
entity: layout_builder.entity
view_mode: view_mode
additional: { }
weight: -9
weight: -8
8a263ac8-9885-4c26-a327-31ce11544df3:
uuid: 8a263ac8-9885-4c26-a327-31ce11544df3
region: third
Expand All @@ -150,7 +150,7 @@ third_party_settings:
context_mapping:
node: layout_builder.entity
additional: { }
weight: -8
weight: -7
c6095adf-087f-4edb-883b-36c3e97238bf:
uuid: c6095adf-087f-4edb-883b-36c3e97238bf
region: first
Expand Down Expand Up @@ -185,6 +185,19 @@ third_party_settings:
view_mode: view_mode
additional: { }
weight: -10
31a68b33-9e47-4b8f-8b01-32b2c0c640b1:
uuid: 31a68b33-9e47-4b8f-8b01-32b2c0c640b1
region: third
configuration:
id: openideal_statistics_status
label: 'Workflow status.'
provider: openideal_statistics
label_display: '0'
show_all_states: false
context_mapping:
node: layout_builder.entity
additional: { }
weight: -9
third_party_settings: { }
id: node.idea.front_page_teaser
targetEntityType: node
Expand Down
6 changes: 3 additions & 3 deletions config/install/image.style.front_page_teaser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ langcode: en
status: true
dependencies: { }
name: front_page_teaser
label: 'Front page teaser (416x162)'
label: 'Front page teaser (781x250)'
effects:
c584ed11-9458-46dc-bfe7-8f4c276d6df0:
uuid: c584ed11-9458-46dc-bfe7-8f4c276d6df0
id: image_scale_and_crop
weight: 1
data:
width: 416
height: 162
width: 781
height: 250
anchor: center-center
Loading

0 comments on commit 544e1a2

Please sign in to comment.