Replace str.removesuffix usage in domain_record module
#229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`str.removesuffix` is new in Python 3.9: https://docs.python.org/3/library/stdtypes.html#str.removesuffix Python 3.7 and 3.8 are still in support: https://devguide.python.org/versions/ On Python 3.7 or 3.8, the `domain_record` module fails with `failed to get domain record example.com: 'str' object has no attribute 'removesuffix'` Python 3.8 is the default version of Python on Ubuntu 20.04 which is how this issue was discovered. This change replaces the only usage of `str.removesuffix` in this repository with a conditional slice to restore compatibility with Python 3.7 and 3.8. This replacement provides the same functionality.
lgarber-akamai
approved these changes
Nov 8, 2022
jriddle-linode
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
str.removesuffixis new in Python 3.9:https://docs.python.org/3/library/stdtypes.html#str.removesuffix
Python 3.7 and 3.8 are still in support:
https://devguide.python.org/versions/
On Python 3.7 or 3.8, the
domain_recordmodule fails withfailed to get domain record example.com: 'str' object has no attribute 'removesuffix'Python 3.8 is the default version of Python on Ubuntu 20.04 which is how this issue was discovered.
This change replaces the only usage of
str.removesuffixin this repository with a conditional slice to restore compatibility with Python 3.7 and 3.8. This replacement provides the same functionality.