Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vlans list module #231

Merged
merged 8 commits into from
Nov 17, 2022
Merged

vlans list module #231

merged 8 commits into from
Nov 17, 2022

Conversation

jriddle-linode
Copy link
Collaborator

@jriddle-linode jriddle-linode commented Nov 8, 2022 •
edited
Loading

enable listing all vlans from GET networking/vlans

Jacob Riddle added 2 commits November 8, 2022 20:21
copied files, started initial changes
a683427 
copied files from images_list
still need to update docs
test not finished need to create a vlan to view
Merge remote-tracking branch 'live/main' into vlanlist
7d68aad
@jriddle-linode jriddle-linode marked this pull request as draft November 8, 2022 20:27
@jriddle-linode jriddle-linode marked this pull request as ready for review November 15, 2022 20:44
lgarber-akamai
lgarber-akamai requested changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Could we rename this module to vlan_list to be inline with the other list modules?

plugins/module_utils/doc_fragments/vlans_list.py Outdated Show resolved Hide resolved
plugins/modules/vlans_list.py Outdated Show resolved Hide resolved
plugins/modules/vlans_list.py Outdated Show resolved Hide resolved
@jriddle-linode jriddle-linode changed the title wip: vlans list module vlans list module Nov 16, 2022
lgarber-akamai
lgarber-akamai approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and all looks good!

@jriddle-linode jriddle-linode merged commit 1913f96 into linode:main Nov 17, 2022
@jriddle-linode jriddle-linode deleted the vlanlist branch November 17, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jriddle-linode @lgarber-akamai