fix: Bypass OAuth errors in lke_cluster_info module
#264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarber-akamai
force-pushed
the
fix/bypass-kubeconfig
branch
from
36bf68c
to
3bae684
Compare
jriddle-linode
approved these changes
Jan 18, 2023
zliang-akamai
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This change adds logic to the
lke_cluster_infomodule to ignore OAuth errors when attempting to obtain a cluster's KubeConfig. This is necessary aslke:read_onlyusers cannot read a cluster's KubeConfig but should be able to get other info about the cluster.Additionally, this change alters the
tokenmodule to return the full PAT after a token is created. This is necessary as the API returns a shortened token on subsequent GET requests.Resolves #261
✔️ How to Test