Use None rather than Empty list #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by None rather than empty list.
|
While it is fine to handle here, it would be nicer if the linode api would handle empty lists in this case and set it to None automatically. |
|
/acctest tests=firewall_update sha=35f54c118edb767c90e22f8e9b0c95714e2e7eed |
lgarber-akamai
approved these changes
Feb 21, 2023
@marcfiu Did you have a chance to notify the Linode API team about this issue? And please let us know when this PR is ready to review as it is still a draft PR. |
zliang-akamai
approved these changes
Feb 22, 2023
lgarber-akamai
approved these changes
Mar 13, 2023
|
/acctest tests=firewall_update sha=08be018c0881ae434ba21a200717006fa1c01d41 |
|
@zliang-akamai : the changes are ready for review. Btw., I have not contacted the Linode API team on treating |
zliang-akamai
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Another untested case for firewall updates yielded improper handling of rules that had either no ipv4 or ipv6 addresses. The code would default to an empty list, while the API wants None in that case.
What does this PR do and why is this change necessary?
Default to None to represent an empty IPvX list in rules.
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
How do I run the relevant unit/integration tests?
use included firewall_update/main.yaml test
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.