ref: Remove status polling in instance module
#299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/acctest sha=6f0c4fe3062bbf8371914141bf813e549b138acf tests=instance_booted |
|
/acctest sha=6f0c4fe3062bbf8371914141bf813e549b138acf tests=instance_config_disk |
zliang-akamai
approved these changes
Feb 24, 2023
Co-authored-by: zliang-akamai <121905282+zliang-akamai@users.noreply.github.com>
|
/acctest sha=2a8a71d827c5de1de19a8598f4a901742f5dc0ce tests=instance_config_disk |
ezilber-akamai-zz
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This change replaces all instances of status polling in the
instancemodule with proper event polling. This is necessary as status-based polling can be unreliable when trying to run certain operations (boot, disk creations, etc.)Additionally, this PR introduces a new
wait_for_resource_free(...)function that waits for a resource to not be busy.✔️ How to Test