Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added zone_file response field to domain and domain_info modules #326

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

ezilber-akamai-zz
Copy link
Contributor

@ezilber-akamai-zz ezilber-akamai-zz commented Mar 29, 2023

📝 Description

Added zone_file response field to domain and domain_info modules

✔️ How to Test

make TEST_ARGS="-v domain_zone_file" test

Ticket: TPT-1849

@ezilber-akamai-zz ezilber-akamai-zz requested a review from a team March 29, 2023 18:09
@lgarber-akamai
Copy link
Contributor

/acctest sha=031ab0cc41ef35b03c27ba6c143779284d2e0628 tests=domain_zone_file

@lgarber-akamai lgarber-akamai requested a review from a team March 30, 2023 14:25
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the zone_file result sample in the domain_info doc fragments as well?

@ezilber-akamai-zz
Copy link
Contributor Author

Should we add the zone_file result sample in the domain_info doc fragments as well?

I think since this doc doesn't have any result samples at all we don't need to.

@lgarber-akamai lgarber-akamai requested a review from a team March 31, 2023 14:15
@lgarber-akamai lgarber-akamai merged commit 0086c80 into linode:dev Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants