Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix body_json parsing of api_request module #342

Merged
merged 4 commits into from
Apr 28, 2023

Conversation

zliang-akamai
Copy link
Member

📝 Description

closes #334

Translate body_json parameter to json to fix an issue that trouble the users.

✔️ How to Test

make TEST_ARGS="-v api_request_extra" test
make TEST_ARGS="-v api_request_basic" test

@zliang-akamai zliang-akamai requested a review from a team April 27, 2023 12:43
@lgarber-akamai
Copy link
Contributor

/acctest tests=api_request_extra sha=9838372270f5a8af29a759bfbe4687065f488f6b

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! This solution is really clever.
Just a small refactor and we should be good to go 👍

plugins/modules/api_request.py Outdated Show resolved Hide resolved
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@zliang-akamai
Copy link
Member Author

/acctest tests=api_request_extra sha=cb460c0495e52ec6d0ebfec3f1281d9e9506e44e

1 similar comment
@zliang-akamai
Copy link
Member Author

/acctest tests=api_request_extra sha=cb460c0495e52ec6d0ebfec3f1281d9e9506e44e

@zliang-akamai zliang-akamai requested a review from a team April 27, 2023 18:52
@zliang-akamai zliang-akamai merged commit e065bbc into linode:dev Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Help]: linode.cloud.api_request
3 participants