-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix body_json parsing of api_request module #342
Conversation
/acctest tests=api_request_extra sha=9838372270f5a8af29a759bfbe4687065f488f6b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! This solution is really clever.
Just a small refactor and we should be good to go 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
0560d90
to
00d47ce
Compare
/acctest tests=api_request_extra sha=cb460c0495e52ec6d0ebfec3f1281d9e9506e44e |
1 similar comment
/acctest tests=api_request_extra sha=cb460c0495e52ec6d0ebfec3f1281d9e9506e44e |
📝 Description
closes #334
Translate
body_json
parameter to json to fix an issue that trouble the users.✔️ How to Test
make TEST_ARGS="-v api_request_extra" test
make TEST_ARGS="-v api_request_basic" test