Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new: ip_assign module #402

Merged
merged 9 commits into from
Sep 14, 2023
Merged

new: ip_assign module #402

merged 9 commits into from
Sep 14, 2023

Conversation

jriddle-linode
Copy link
Collaborator

📝 Description

What does this PR do and why is this change necessary?

adding ip_assign module

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?

How do I run the relevant unit/integration tests?

make TEST_ARGS="-v ip_assign" test

@jriddle-linode jriddle-linode requested a review from a team as a code owner August 15, 2023 20:28
lgarber-akamai
lgarber-akamai requested changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far!

plugins/modules/ip_assign.py Outdated Show resolved Hide resolved
yec-akamai
yec-akamai reviewed Aug 21, 2023
View reviewed changes
plugins/modules/ip_assign.py Outdated Show resolved Hide resolved
plugins/modules/ip_assign.py Outdated Show resolved Hide resolved
plugins/modules/ip_assign.py Outdated Show resolved Hide resolved
tests/integration/targets/ip_assign/tasks/main.yml Show resolved Hide resolved
lgarber-akamai
lgarber-akamai requested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far! Just a few small changes

plugins/module_utils/doc_fragments/ip_assign.py Show resolved Hide resolved
plugins/modules/ip_assign.py Outdated Show resolved Hide resolved
plugins/modules/ip_assign.py Outdated Show resolved Hide resolved
@jriddle-linode jriddle-linode requested review from lgarber-akamai and a team August 30, 2023 19:18
lgarber-akamai
lgarber-akamai requested changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one more small thing and this should be good to go

plugins/modules/ip_assign.py Show resolved Hide resolved
lgarber-akamai
lgarber-akamai approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just needs a make gendocs run and a few small changes to fix the linting errors 👍

@jriddle-linode jriddle-linode requested a review from a team September 11, 2023 16:08
@zliang-akamai
Copy link
Member

zliang-akamai commented Sep 13, 2023 •
edited
Loading

Test run: https://github.com/linode/ansible_linode/actions/runs/6177081277
(passed)

@jriddle-linode jriddle-linode merged commit de79912 into linode:dev Sep 14, 2023
4 checks passed
@jriddle-linode jriddle-linode deleted the new/ipassign branch September 14, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zliang-akamai zliang-akamai zliang-akamai approved these changes

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes

@yec-akamai yec-akamai Awaiting requested review from yec-akamai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jriddle-linode @zliang-akamai @lgarber-akamai @yec-akamai