Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Add support for specifying a firewall_id on instance creation #416

Merged

Conversation

lgarber-akamai
Copy link
Contributor

@lgarber-akamai lgarber-akamai commented Sep 25, 2023

📝 Description

This change adds support for specifying a firewall_id when creating an instance using the linode.cloud.instance module.

NOTE: This feature has not yet been enabled in the API.

✔️ How to Test

make TEST_ARGS="-v instance_firewall" test

@lgarber-akamai lgarber-akamai changed the title new: (WIP) Add support for specifying a firewall_id on instance creation new: Add support for specifying a firewall_id on instance creation Sep 26, 2023
@lgarber-akamai lgarber-akamai marked this pull request as ready for review September 26, 2023 15:05
@lgarber-akamai lgarber-akamai requested a review from a team as a code owner September 26, 2023 15:05
@lgarber-akamai lgarber-akamai added the do-not-merge PRs that should not be merged until the commented issue is resolved label Sep 26, 2023
@zliang-akamai zliang-akamai self-requested a review October 2, 2023 16:18
@zliang-akamai zliang-akamai removed the do-not-merge PRs that should not be merged until the commented issue is resolved label Oct 2, 2023
@zliang-akamai zliang-akamai requested a review from a team October 2, 2023 19:30
@zliang-akamai
Copy link
Member

I think it's now enabled on alpha.

@zliang-akamai zliang-akamai requested a review from a team October 3, 2023 14:37
@zliang-akamai zliang-akamai merged commit 84864bb into linode:proj/vpc Oct 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants