Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve issue that causes make unittest and make install to fail #454

Merged

Conversation

lgarber-akamai
Copy link
Contributor

@lgarber-akamai lgarber-akamai commented Jan 2, 2024

📝 Description

This change resolves two issues that caused the make unittest and make install targets to fail on certain machines:

  • The PyTest Ansible plugin (pytest-ansible) package was being explicitly installed but is now provided directly in the ansible package, causing a conflict.
  • The collections symlink was not being ignored in the galaxy.yml file, leading to an error when attempting to resolve the link during install
    • Unexpected Exception, this is probably a bug: "linkname 'collections/ansible_collections/linode/cloud/../../../../Makefile' not found"

✔️ How to Test

  1. Clone a fresh copy of this PR.
mkdir -p testproject/ansible_collections/linode
cd testproject/ansible_collections/linode
git clone --branch fix/install-unit-test-errors git@github.com:lgarber-akamai/ansible_linode.git cloud
cd cloud
  1. Install the project dependencies.
make deps
  1. Attempt to run unit tests on the collection.
make unittest
  1. Attempt to install the collection.
make install
  1. Observe that none of the previous steps failed.

@lgarber-akamai lgarber-akamai requested a review from a team as a code owner January 2, 2024 17:53
@lgarber-akamai lgarber-akamai requested review from jriddle-linode and zliang-akamai and removed request for a team January 2, 2024 17:53
@lgarber-akamai lgarber-akamai changed the title fix: Resolve issue that caused make unittest and make install to fail fix: Resolve issue that causes make unittest and make install to fail Jan 2, 2024
@lgarber-akamai lgarber-akamai merged commit 1eab546 into linode:dev Jan 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants