-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: Add modules for Placement group #503
new: Add modules for Placement group #503
Conversation
"failed to update instance {0}: placement_group.id is a " | ||
"non-updatable field".format(self._instance.label) | ||
) | ||
if pg.get("compliant_only"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lgarber-akamai The value of compliant_only
is not returned from API and we don't have a state like tf to find its old value, so I'm thinking returning a warning here to remind user that compliant_only is not updatable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All E2E test are passing and everything works as expected in my manual testing, great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested and worked well. Nice work!
📝 Description
This PR includes the following change for VM placement functionalities:
Add new modules:
In the
instance
module, allow to create a new linode instance under a placement group.✔️ How to Test
Run
pip install --force -r requirements.txt
to install required dependencies.Also, you need to set up environment variables to test against alpha:
Integration tests:
Manual Test:
Observe no error is raised.
Create an instance under the placement group
Observe that the instance is created successfully.
Clean up the resources created.