doc: Add deprecation notice to OBJ cluster-related modules & fields #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarber-akamai
added
the
documentation
lgarber-akamai
requested review from
jriddle-linode and
yec-akamai
and removed request for
a team,
jriddle-linode and
yec-akamai
lgarber-akamai
added
the
do-not-merge
lgarber-akamai
commented
Jun 24, 2024
Comment on lines
+179
to
+183
| # If cluster has been defined for any of the `access` objects, | ||
| # raise a deprecation warning | ||
| if access is not None and any( | ||
| v is not None for v in access if v.get("cluster", None) | ||
| ): |
There was a problem hiding this comment.
@zliang-akamai I think this deprecation will be dependent on TPT-2603, do you mind if I mark this PR as do not merge until that work is done?
jriddle-linode
approved these changes
Jun 26, 2024
zliang-akamai
approved these changes
Jun 26, 2024
lgarber-akamai
removed
the
do-not-merge
|
Merged this pull request because it was re-pointed to the multicluster project branch 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request adds warnings to the documentation for fields and modules related to the OBJ
clusterfield, which is being deprecated as part of the Multicluster OBJ project.✔️ How to Test
N/A