Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update firewall scripts in submodule to allow alpha testing #534

Merged
merged 1 commit into from
Jul 3, 2024
Merged

test: Update firewall scripts in submodule to allow alpha testing #534

merged 1 commit into from
Jul 3, 2024

Conversation

ykim-akamai
Copy link
Contributor

@ykim-akamai ykim-akamai commented Jul 2, 2024 •
edited
Loading

📝 Description

The firewall generation script now supports testing with alpha environment.

✔️ How to Test

The following variables needs to be set for alpha env:

 export LINODE_TOKEN=
 export TEST_API_CA=
 export TEST_API_URL=

make create-e2e-firewall

Once firewall is successfully created, delete the firewall:

make delete-e2e-firewall

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai requested a review from a team as a code owner July 2, 2024 17:02
@ykim-akamai ykim-akamai requested review from zliang-akamai and ezilber-akamai and removed request for a team July 2, 2024 17:02
yec-akamai
yec-akamai approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well in alpha, nice work!

ezilber-akamai
ezilber-akamai approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests worked. LGTM!

@ykim-akamai ykim-akamai merged commit 110cea8 into linode:dev Jul 3, 2024
4 checks passed
@jriddle-linode jriddle-linode added the testing for updates to the testing suite in the changelog. label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezilber-akamai ezilber-akamai ezilber-akamai approved these changes

@yec-akamai yec-akamai yec-akamai approved these changes

@zliang-akamai zliang-akamai Awaiting requested review from zliang-akamai zliang-akamai is a code owner automatically assigned from linode/dx

Assignees
No one assigned
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykim-akamai @yec-akamai @ezilber-akamai @jriddle-linode