Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swap_size to instance_spec config #554

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

yec-akamai
Copy link
Contributor

📝 Description

swap_size was a missing attributes. Adding it to the linode_instance_spec and allow user to specify it when creating a Linode.

✔️ How to Test

make TEST_ARGS="-v instance_booted" test

Manual Test:

  1. In a sandbox environment, i.e. dx-devenv, run the following playbook:
    - name: Create a booted Linode instance
      linode.cloud.instance:
        label: ansible-test-instance
        region: us-ord
        type: g6-standard-1
        image: linode/ubuntu22.04
        root_pass: Fn$$oobar123
        private_ip: true
        booted: true
        swap_size: 512
        state: present
  1. Observe that the linode instance is created successfully. (swap_size won't be returned in the response though.)

@yec-akamai yec-akamai added the improvement for improvements in existing functionality in the changelog. label Jul 30, 2024
@yec-akamai yec-akamai requested a review from a team as a code owner July 30, 2024 20:47
@yec-akamai yec-akamai requested review from zliang-akamai and ykim-akamai and removed request for a team July 30, 2024 20:47
@zliang-akamai
Copy link
Member

I am surprised we didn't have this, lol

Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@yec-akamai yec-akamai merged commit 20b6a72 into linode:dev Aug 2, 2024
4 checks passed
@yec-akamai yec-akamai deleted the TPT-2823/add-swap-size branch August 2, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants