Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated StackScript list module to new framework #571

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Migrated stackscript_list module to new framework.

✔️ How to Test

Integration Testing

`make TEST_ARGS="-v stackscript_list" test

Manual Testing

  1. In an ansible_linode sandbox environment (e.g. dx-devenv), run the following:
- name: ansible_linode Sandbox Playbook
  hosts: localhost
  tasks:
    - name: Create a stackscript
      linode.cloud.stackscript:
        label: 'test-stackscript'
        images: [ 'linode/alpine3.19' ]
        script: |
          #!/bin/bash
          # <UDF name="package" label="System Package to Install" example="nginx" default="">
          apt-get -q update && apt-get -q -y install $PACKAGE
        state: present
      register: stackscript

    - name: List stackscripts with no filter
      linode.cloud.stackscript_list:
      register: no_filter

    - name: List stackscripts with filter on label
      linode.cloud.stackscript_list:
        filters:
          - name: label
            values: test-stackscript
      register: filter_label
  1. Ensure that the StackScript list is returned and filtered properly.
  2. Ensure that the newly created stackscripts have been successfully deleted.

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner August 20, 2024 20:09
@ezilber-akamai ezilber-akamai requested review from lgarber-akamai and ykim-akamai and removed request for a team August 20, 2024 20:09
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing locally, great work!

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified locally. Nice work!

@ezilber-akamai ezilber-akamai merged commit da6cea0 into linode:dev Aug 22, 2024
4 checks passed
@ezilber-akamai ezilber-akamai deleted the TPT-2933-stackscript-list branch August 22, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants