Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Migrate lke_version_list to use common list info #573

Merged

Conversation

yec-akamai
Copy link
Contributor

📝 Description

Migrate the lke_version_list to use the common list info for better maintainability.

✔️ How to Test

make TEST_ARGS="-v lke_version_list" test

Manual Test:

  1. In a sandbox environment, run the following playbook script to list lke versions
- name: test
  hosts: localhost
  tasks:
    - name: List lke_version_list
      linode.cloud.lke_version_list:
  1. Observe the versions are successfully listed.

@yec-akamai yec-akamai requested a review from a team as a code owner August 22, 2024 14:32
@yec-akamai yec-akamai requested review from jriddle-linode and zliang-akamai and removed request for a team August 22, 2024 14:32
Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and worked great!

Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally and looks much cleaner!

@yec-akamai yec-akamai merged commit 0ce1e79 into linode:dev Sep 3, 2024
4 checks passed
@yec-akamai yec-akamai deleted the TPT-2927/migrate-lke-version-list branch September 3, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants