Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated SSH-Key-related info and list modules to new framework #577

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Migrated ssh_key_info and ssh_key_list modules to new framework.

✔️ How to Test

Integration Tests

make TEST_ARGS="-v ssh_key_list ssh_key_info" test

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner August 23, 2024 13:57
@ezilber-akamai ezilber-akamai requested review from jriddle-linode and yec-akamai and removed request for a team August 23, 2024 13:57
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing on my end and implementation looks good, nice work!

@ezilber-akamai ezilber-akamai added the improvement for improvements in existing functionality in the changelog. label Aug 26, 2024
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests passed locally!

@ezilber-akamai ezilber-akamai merged commit abd4b35 into linode:dev Aug 28, 2024
4 checks passed
@ezilber-akamai ezilber-akamai deleted the TPT-2932-ssh-info-list branch August 28, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants