Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated User-related list module to new framework #578

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Migrated user_list module to new framework.

Note: user_info module was already migrated.

✔️ How to Test

Integration Tests

make TEST_ARGS="-v user_list" test

Manual Tests

  1. In an ansible_linode sandbox environment (e.g. dx-devenv), run the following:
- name: test
  hosts: localhost
  tasks:
    - name: Create a Linode User
      linode.cloud.user:
        username: 'testing-user-1'
        email: 'testing-user-1@linode.com'
        state: present
      register: create_user_1

    - name: Create another Linode User
      linode.cloud.user:
        username: 'testing-user-2'
        email: 'testing-user-2@linode.com'
        state: present
      register: create_user_2

    - name: List users with no filter
      linode.cloud.user_list:
      register: no_filter

    - name: List users with a filter on username
      linode.cloud.user_list:
        filters:
          - name: username
            values: testing-user-1
      register: filter_username

    - name: Delete a Linode User
      linode.cloud.user:
        username: '{{ create_user_1.user.username }}'
        state: absent

    - name: Delete a Linode User
      linode.cloud.user:
        username: '{{ create_user_2.user.username }}'
        state: absent
  1. Ensure that the user list is returned and filtered properly.

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner August 23, 2024 18:11
@ezilber-akamai ezilber-akamai requested review from zliang-akamai and yec-akamai and removed request for a team August 23, 2024 18:11
@ezilber-akamai ezilber-akamai added the improvement for improvements in existing functionality in the changelog. label Aug 26, 2024
Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, nice job!

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work!

@ezilber-akamai ezilber-akamai merged commit 93cb64b into linode:dev Aug 27, 2024
4 checks passed
@ezilber-akamai ezilber-akamai deleted the TPT-2936-user-info-list branch August 27, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants