-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add slack notifications to integraion test workflow #592
test: Add slack notifications to integraion test workflow #592
Conversation
@@ -78,7 +78,7 @@ jobs: | |||
process-upload-report: | |||
runs-on: ubuntu-latest | |||
needs: [run-tests] | |||
if: always() # Run even if previous job fails | |||
if: always() && github.repository == 'linode/ansible_linode' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, does this ensure reports aren't uploaded on forks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah exactly. I wanted to refine what gets uploaded to TOD and not get any false failures on builds due to process-upload-report
step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
📝 Description
✔️ How to Test
will monitor the workflow and notifications after merge.
📷 Preview
e.g.