Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add slack notifications to integraion test workflow #592

Conversation

ykim-akamai
Copy link
Contributor

📝 Description

  • Add slack notifications to integraion test workflow

✔️ How to Test

will monitor the workflow and notifications after merge.

📷 Preview

e.g.
image

@ykim-akamai ykim-akamai requested a review from a team as a code owner September 26, 2024 22:22
@ykim-akamai ykim-akamai requested review from lgarber-akamai and yec-akamai and removed request for a team September 26, 2024 22:22
@@ -78,7 +78,7 @@ jobs:
process-upload-report:
runs-on: ubuntu-latest
needs: [run-tests]
if: always() # Run even if previous job fails
if: always() && github.repository == 'linode/ansible_linode'
Copy link
Contributor

@lgarber-akamai lgarber-akamai Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, does this ensure reports aren't uploaded on forks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah exactly. I wanted to refine what gets uploaded to TOD and not get any false failures on builds due to process-upload-report step

Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ykim-akamai ykim-akamai merged commit 9aa32d9 into linode:dev Sep 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants