Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup, upgrade, and re-organize dependencies #619

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

zliang-akamai
Copy link
Member

@zliang-akamai zliang-akamai commented Nov 5, 2024

📝 Description

This is to organize all dependencies

integration test: https://github.com/linode/ansible_linode/actions/runs/11690045146

  1. Downgrade types-requests to 2.32.0.20240914 because newer version requiring urllib3>=2, which is not compatible with Python 3.9.
  2. Move types-requests to dev requirements becauase it's only needed for linters.
  3. Upgrade py-version to 3.9 for pylint.
  4. Remove EOL Python versions and add 3.12 for black.
  5. Pin version of polling to 0.3.2 because it's a third party package. (we should consider its fork, polling2, because polling is no longer maintained)

@zliang-akamai zliang-akamai requested a review from a team as a code owner November 5, 2024 17:49
@zliang-akamai zliang-akamai requested review from ykim-akamai and yec-akamai and removed request for a team November 5, 2024 17:49
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for addressing this!

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for looking into this!

@zliang-akamai zliang-akamai merged commit 1343489 into dev Nov 6, 2024
10 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/cleanup-upgrade-organize-deps branch November 6, 2024 00:14
@zliang-akamai zliang-akamai added the dependencies dependency updates usually from dependabot label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies dependency updates usually from dependabot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants