-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing tags to volumes using the storage class #133
Conversation
add to the howto in the readme how to do this without the helm chart? |
Tested by installing the helm chart with allowTags set to
I've got a teleport pv created
Querying the Linode API for volumes - you can see that the volume has a tag on it
|
Yes - added |
@@ -7,5 +7,9 @@ metadata: | |||
annotations: | |||
storageclass.kubernetes.io/is-default-class: "true" | |||
{{- end }} | |||
{{- if .Values.addTags }} | |||
parameters: | |||
linodebs.csi.linode.com/volumeTags: "{{ .Values.addTags }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this simply be "{{ .Values.volumeTags }}" instead of "addTags" , to match the parameter name?
General:
Adds a new feature to pass tags to linode volumes created by the CSI driver. It is currently not possible to set an annotation on the PVC and get the csi-driver to read the annotation due to kubernetes-csi/external-provisioner#86
Choosing to take the approach of passing tags via StorageClass parameters instead.
This closes #132
Pull Request Guidelines: