test: Randomize root pass for Linode creations in integration tests (#…

…433) * randomize all rootPass upon instance creation * update fixtures
linode · Dec 5, 2023 · d853175 · d853175
1 parent f5c858a
commit d853175
Show file tree

Hide file tree

Showing 9 changed files with 1,656 additions and 77,640 deletions.
diff --git a/test/integration/example_integration_test.go b/test/integration/example_integration_test.go
@@ -347,8 +347,6 @@ func randString(length int, characterClasses ...string) string {
 	return string(b)
 }
 
-// randPassword generates a password sufficient to pass the Linode API standards,
-// don't use it outside of this example script where the Linode is immediately destroyed.
 func randPassword() string {
 	return randString(64, lowerBytes, upperBytes, digits, symbols)
 }

diff --git a/test/integration/example_nodebalancers_test.go b/test/integration/example_nodebalancers_test.go
@@ -154,7 +154,7 @@ func ExampleClient_CreateNodeBalancerNode() {
 	booted := false
 	instanceOpts := linodego.InstanceCreateOptions{
 		Label:    "nodebalancer-example-instance",
-		RootPass: "R34lBAdP455!!!",
+		RootPass: randPassword(),
 		Region:   "us-southeast",
 		Type:     "g6-nanode-1",
 		Image:    "linode/debian9",

diff --git a/test/integration/fixtures/TestEventPoller_InstancePower.yaml b/test/integration/fixtures/TestEventPoller_InstancePower.yaml
diff --git a/test/integration/fixtures/TestInstance_Disk_ListMultiple_Primary.yaml b/test/integration/fixtures/TestInstance_Disk_ListMultiple_Primary.yaml
diff --git a/test/integration/fixtures/TestInstance_Disk_ListMultiple_Secondary.yaml b/test/integration/fixtures/TestInstance_Disk_ListMultiple_Secondary.yaml
diff --git a/test/integration/fixtures/TestInstance_Disk_ResetPassword.yaml b/test/integration/fixtures/TestInstance_Disk_ResetPassword.yaml
diff --git a/test/integration/fixtures/TestWaitForResourceFree.yaml b/test/integration/fixtures/TestWaitForResourceFree.yaml
diff --git a/test/integration/instances_test.go b/test/integration/instances_test.go
@@ -180,7 +180,7 @@ func TestInstance_Disk_ListMultiple(t *testing.T) {
 	_, err = client.CreateInstanceDisk(context.Background(), instance2.ID, linodego.InstanceDiskCreateOptions{
 		Label:    "go-disk-test-" + randLabel(),
 		Image:    image.ID,
-		RootPass: "R34lBAdP455LONGLONGLONGLONG",
+		RootPass: randPassword(),
 		Size:     2000,
 	})
 	if err != nil {
@@ -221,7 +221,7 @@ func TestInstance_Disk_ResetPassword(t *testing.T) {
 		Label:      "go-disk-test-" + randLabel(),
 		Filesystem: "ext4",
 		Image:      "linode/debian9",
-		RootPass:   "R34lBAdP455LONGLONGLONGLONG",
+		RootPass:   randPassword(),
 		Size:       2000,
 	})
 	if err != nil {
@@ -329,7 +329,7 @@ func TestInstance_Rebuild(t *testing.T) {
 		Metadata: &linodego.InstanceMetadataOptions{
 			UserData: base64.StdEncoding.EncodeToString([]byte("cool")),
 		},
-		RootPass: "R34lBAdP455LONGLONGLONGLONG",
+		RootPass: randPassword(),
 		Type:     "g6-standard-2",
 	}
 	instance, err = client.RebuildInstance(context.Background(), instance.ID, rebuildOpts)
@@ -451,7 +451,7 @@ func createInstance(t *testing.T, client *linodego.Client, modifiers ...instance
 	booted := false
 	createOpts := linodego.InstanceCreateOptions{
 		Label:    "go-test-ins-" + randLabel(),
-		RootPass: "R34lBAdP455LONGLONGLONGLONG",
+		RootPass: randPassword(),
 		Region:   getRegionsWithCaps(t, client, []string{"linodes"})[0],
 		Type:     "g6-nanode-1",
 		Image:    "linode/debian9",

diff --git a/test/integration/waitfor_test.go b/test/integration/waitfor_test.go
@@ -22,7 +22,7 @@ func TestEventPoller_InstancePower(t *testing.T) {
 		Region:   getRegionsWithCaps(t, client, []string{"Linodes"})[0],
 		Type:     "g6-nanode-1",
 		Image:    "linode/ubuntu22.04",
-		RootPass: "R34lBAdP455LONGLONGLONGLONG",
+		RootPass: randPassword(),
 		Label:    "go-ins-poll-test",
 		Booted:   &booted,
 	})
@@ -106,7 +106,7 @@ func TestWaitForResourceFree(t *testing.T) {
 		Region:   getRegionsWithCaps(t, client, []string{"Linodes"})[0],
 		Type:     "g6-nanode-1",
 		Image:    "linode/ubuntu22.04",
-		RootPass: "c00lp@sgfdgregrhn$!!!!",
+		RootPass: randPassword(),
 		Label:    "linodego-waitforfree",
 	})
 	if err != nil {