Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ICMP protocol value #136

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Conversation

0xch4z
Copy link
Contributor

@0xch4z 0xch4z commented Apr 11, 2020

No description provided.

@0xch4z 0xch4z requested a review from phillc April 11, 2020 20:22
@phillc
Copy link
Contributor

phillc commented Apr 11, 2020

If found via a bug, perhaps it needs a test to be filled in.

@0xch4z
Copy link
Contributor Author

0xch4z commented Apr 11, 2020

If found via a bug, perhaps it needs a test to be filled in.

I will cover this in my next PR coming shortly for implementing client.GetFirewall

@0xch4z 0xch4z merged commit 6ab34a6 into linode:master Apr 11, 2020
@phillc phillc added the bugfix for any bug fixes in the changelog. label Apr 15, 2020
LBGarber pushed a commit to LBGarber/linodego that referenced this pull request Mar 15, 2021
…allow-no-name

dont require name for non-SRV domain records
lgarber-akamai pushed a commit to lgarber-akamai/linodego that referenced this pull request Feb 13, 2023
lgarber-akamai pushed a commit to lgarber-akamai/linodego that referenced this pull request Feb 13, 2023
lgarber-akamai pushed a commit to lgarber-akamai/linodego that referenced this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix for any bug fixes in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants