all timestamps should be pointers #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillc
reviewed
May 27, 2020
There was a problem hiding this comment.
If the api isn't returning a value, then we are assigning the default value of the time type to Created/Updated.
Perhaps instead, the Created/Updated on the struct need to become pointers.
Alternatively/in conjunction we should investigate the scenarios where this happens.
0xch4z
force-pushed
the
safer-date-parsing
branch
from
2b1ba64 to
e83cc28
Compare
0xch4z
changed the title
phillc
approved these changes
May 27, 2020
LBGarber
pushed a commit
to LBGarber/linodego
that referenced
this pull request
Mar 15, 2021
remove all resources Exists funcs
lgarber-akamai
pushed a commit
to lgarber-akamai/linodego
that referenced
this pull request
Feb 13, 2023
all timestamps should be pointers
lgarber-akamai
pushed a commit
to lgarber-akamai/linodego
that referenced
this pull request
Feb 13, 2023
all timestamps should be pointers
lgarber-akamai
pushed a commit
to lgarber-akamai/linodego
that referenced
this pull request
Feb 13, 2023
all timestamps should be pointers
lgarber-akamai
pushed a commit
to lgarber-akamai/linodego
that referenced
this pull request
Feb 14, 2023
all timestamps should be pointers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes all dereferences of timestamps on resources that don't use pointers.Sometimes, mysteriously, the API can omit timestamps. With these implementations ofUnmarshalJSON, a panic will occur because of a 'nil dereference' (like with terraform-providers/terraform-provider-linode#152).This change changes all
time.Timefields on resources to*time.Time.