-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: Add support for Parent/Child account switching #455
new: Add support for Parent/Child account switching #455
Conversation
Add UserType enum Add test case for user type User fixtures Add unit tests Oops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Existing tests are passing 👍
11d1ad7
to
947e706
Compare
fff9d05
to
60432b9
Compare
Going to convert this back to a draft while I work to break some of the smaller changes into separate PRs |
9ff2ee2
to
0555ea3
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else tested and looks good!
@zliang-akamai Oops, looks like it was accidentally dropped when I was fixing some merge conflicts. I can fix it real quick 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Change looks good to me.
Unit tests and user tests passed locally. I still don't have the 1pass vault set up for my account, so can't run through the parent/child integration tests on my end.
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/linode/linodego](https://github.com/linode/linodego) | `v1.34.0` -> `v1.35.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2flinode%2flinodego/v1.35.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2flinode%2flinodego/v1.35.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2flinode%2flinodego/v1.34.0/v1.35.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2flinode%2flinodego/v1.34.0/v1.35.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>linode/linodego (github.com/linode/linodego)</summary> ### [`v1.35.0`](https://github.com/linode/linodego/releases/tag/v1.35.0) [Compare Source](https://github.com/linode/linodego/compare/v1.34.0...v1.35.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### 🚀 New Features - Add support for Parent/Child account switching by [@​lgarber-akamai](https://github.com/lgarber-akamai) and [@​jriddle-linode](https://github.com/jriddle-linode) in [linode/linodego#455 and [linode/linodego#513 ##### 📖 Documentation - Format code example in README by [@​zliang-akamai](https://github.com/zliang-akamai) in [linode/linodego#510 **Full Changelog**: linode/linodego@v1.34.0...v1.35.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/anza-labs/lke-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODguMSIsInVwZGF0ZWRJblZlciI6IjM3LjM4OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhcmVhL2RlcGVuZGVuY3kiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
📝 Description
This change adds preemptive support for the Parent/Child Account Switching feature, including the following changes:
UserType
fieldIn addition to the above changes, this change brings the
linodego.Account
struct up to parity with the current API response.This change also makes the following testing/helper changes:
test
package now has aunit
directory for storing mock teststest
package now importstestify/require
to make tests more conciseDepends on #458
✔️ How to Test
The following test steps assume you have pulled down this PR locally and are using the token and URL for a parent account in dev.
Unit Testing
E2E Testing
Manual Testing