-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: [BREAKING] Add support for LKE Control Plane ACL #495
Merged
+857
−22
Merged
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1b76e39
Initial implementation; needs testing
lgarber-akamai a659686
Fix control plane omit empty
lgarber-akamai 11e155d
Add integration tests
lgarber-akamai 7586273
Update IPv6 address
lgarber-akamai 4b90dea
Add event actions
lgarber-akamai 64cd278
Account for fixture sanitization
lgarber-akamai d6a95bf
make tidy
lgarber-akamai 487a716
oops
lgarber-akamai 1bbab93
oops again
lgarber-akamai f2219b4
Make enabled a *bool
lgarber-akamai 4deed73
[PROPOSED] breaking change
lgarber-akamai 6f2d419
fix test
lgarber-akamai ac5c248
Use pointers for addresses
lgarber-akamai a8843f9
Reorder for readability
lgarber-akamai eb93d5f
Merge branch 'main' into new/lke-acl
lgarber-akamai 34c518a
Address comment feedback
lgarber-akamai 8a03d7a
Fix conflict
lgarber-akamai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| package linodego | ||
|
|
||
| import "context" | ||
|
|
||
| // LKEClusterControlPlaneACLAddresses describes the | ||
| // allowed IP ranges for an LKE cluster's control plane. | ||
| type LKEClusterControlPlaneACLAddresses struct { | ||
| IPv4 []string `json:"ipv4,omitempty"` | ||
| IPv6 []string `json:"ipv6,omitempty"` | ||
| } | ||
|
|
||
| // LKEClusterControlPlaneACL describes the ACL configuration | ||
| // for an LKE cluster's control plane. | ||
| type LKEClusterControlPlaneACL struct { | ||
| Enabled *bool `json:"enabled,omitempty"` | ||
| Addresses *LKEClusterControlPlaneACLAddresses `json:"addresses,omitempty"` | ||
| } | ||
|
|
||
| // LKEClusterControlPlaneACLUpdateOptions represents the options | ||
| // available when updating the ACL configuration of an LKE cluster's | ||
| // control plane. | ||
| type LKEClusterControlPlaneACLUpdateOptions struct { | ||
| ACL LKEClusterControlPlaneACL `json:"acl"` | ||
| } | ||
|
|
||
| // LKEClusterControlPlaneACLResponse represents the response structure | ||
| // for the Client.GetLKEClusterControlPlaneACL(...) method. | ||
| type LKEClusterControlPlaneACLResponse struct { | ||
| ACL LKEClusterControlPlaneACL `json:"acl"` | ||
| } | ||
|
|
||
| // GetLKEClusterControlPlaneACL gets the ACL configuration for the | ||
| // given cluster's control plane. | ||
| func (c *Client) GetLKEClusterControlPlaneACL(ctx context.Context, clusterID int) (*LKEClusterControlPlaneACLResponse, error) { | ||
| return doGETRequest[LKEClusterControlPlaneACLResponse]( | ||
| ctx, | ||
| c, | ||
| formatAPIPath("lke/clusters/%d/control_plane_acl", clusterID), | ||
| ) | ||
| } | ||
|
|
||
| // UpdateLKEClusterControlPlaneACL gets the ACL configuration for the | ||
| // given cluster's control plane. | ||
| func (c *Client) UpdateLKEClusterControlPlaneACL( | ||
| ctx context.Context, | ||
| clusterID int, | ||
| opts LKEClusterControlPlaneACLUpdateOptions, | ||
| ) (*LKEClusterControlPlaneACLResponse, error) { | ||
| return doPUTRequest[LKEClusterControlPlaneACLResponse]( | ||
| ctx, | ||
| c, | ||
| formatAPIPath("lke/clusters/%d/control_plane_acl", clusterID), | ||
| opts, | ||
| ) | ||
| } | ||
|
|
||
| // DeleteLKEClusterControlPlaneACL deletes the ACL configuration for the | ||
| // given cluster's control plane. | ||
| func (c *Client) DeleteLKEClusterControlPlaneACL( | ||
| ctx context.Context, | ||
| clusterID int, | ||
| ) error { | ||
| return doDELETERequest( | ||
| ctx, | ||
| c, | ||
| formatAPIPath("lke/clusters/%d/control_plane_acl", clusterID), | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was originally added in the parent/child project branch