Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated instance_ips to kernels to request helpers #537

Merged
merged 8 commits into from
Jul 5, 2024
Merged

Migrated instance_ips to kernels to request helpers #537

merged 8 commits into from
Jul 5, 2024

Conversation

ezilber-akamai
Copy link
Contributor

@ezilber-akamai ezilber-akamai commented Jun 27, 2024 •
edited
Loading

📝 Description

Migrated the following files to use request helpers:

  • instance_ips.go
  • instance_snapshots.go
  • instance_stats.go
  • instance_volumes.go
  • instances.go
  • kernels.go

@ezilber-akamai ezilber-akamai force-pushed the TPT-2874_instance_ips_-kernels branch from 8199a39 to ecb0744 Compare July 1, 2024 13:07
@ezilber-akamai ezilber-akamai reopened this Jul 1, 2024
@ezilber-akamai ezilber-akamai force-pushed the TPT-2874_instance_ips_-kernels branch from e02014e to 2497abf Compare July 1, 2024 14:50
@ezilber-akamai ezilber-akamai marked this pull request as ready for review July 1, 2024 16:25
@ezilber-akamai ezilber-akamai requested a review from a team as a code owner July 1, 2024 16:25
@ezilber-akamai ezilber-akamai requested review from jriddle-linode and zliang-akamai and removed request for a team July 1, 2024 16:25
jriddle-linode
jriddle-linode approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working locally, looks good!

lgarber-akamai
lgarber-akamai approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for moving the legacy PaginatedResponse structs to the new system 🎉

@ezilber-akamai ezilber-akamai merged commit bd61260 into linode:main Jul 5, 2024
4 checks passed
@ezilber-akamai ezilber-akamai deleted the TPT-2874_instance_ips_-kernels branch July 5, 2024 17:41
@shanduur shanduur mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jriddle-linode jriddle-linode jriddle-linode approved these changes

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes

@zliang-akamai zliang-akamai Awaiting requested review from zliang-akamai zliang-akamai is a code owner automatically assigned from linode/dx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezilber-akamai @jriddle-linode @lgarber-akamai