Implemented new logging system #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
requested review from
ykim-akamai and
yec-akamai
and removed request for
a team
ezilber-akamai
force-pushed
the
TPT-2964-new-logging-system
branch
from
ea2ad1c
to
7088c6c
Compare
ezilber-akamai
force-pushed
the
TPT-2964-new-logging-system
branch
2 times, most recently
from
db2384d
to
c8f692a
Compare
ezilber-akamai
force-pushed
the
TPT-2964-new-logging-system
branch
from
c8f692a
to
7bdd3de
Compare
ezilber-akamai
force-pushed
the
TPT-2964-new-logging-system
branch
from
18f6349
to
3fa0585
Compare
ezilber-akamai
force-pushed
the
TPT-2964-new-logging-system
branch
from
a0a4840
to
dcf2cf5
Compare
lgarber-akamai
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Tested locally and the logs look great!
2024/08/01 15:33:24.874594 DEBUG RESTY Sending request:
Method: GET
URL: http://127.0.0.1:64109
Headers: map[Accept:[application/json] Content-Type:[application/json]]
Body:
2024/08/01 15:33:24.875046 DEBUG RESTY Received response:
Status: 200 OK
Headers: map[Content-Length:[21] Content-Type:[text/plain; charset=utf-8] Date:[Thu, 01 Aug 2024 19:33:24 GMT]]
Body: {"message":"success"}
lgarber-akamai
approved these changes
Aug 1, 2024
Thanks for the review! |
ezilber-akamai
added
the
improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Implemented new logging system that no longer relies on resty.
✔️ How to Test
Unit Tests
make testunit