Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented new logging system #562

Merged

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Implemented new logging system that no longer relies on resty.

✔️ How to Test

Unit Tests

make testunit

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner July 30, 2024 17:42
@ezilber-akamai ezilber-akamai requested review from ykim-akamai and yec-akamai and removed request for a team July 30, 2024 17:42
client.go Outdated Show resolved Hide resolved
@ezilber-akamai ezilber-akamai force-pushed the TPT-2964-new-logging-system branch 2 times, most recently from db2384d to c8f692a Compare July 30, 2024 18:45
client.go Outdated Show resolved Hide resolved
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and the logs look great!

2024/08/01 15:33:24.874594 DEBUG RESTY Sending request:
Method: GET
URL: http://127.0.0.1:64109
Headers: map[Accept:[application/json] Content-Type:[application/json]]
Body: 

2024/08/01 15:33:24.875046 DEBUG RESTY Received response:
Status: 200 OK
Headers: map[Content-Length:[21] Content-Type:[text/plain; charset=utf-8] Date:[Thu, 01 Aug 2024 19:33:24 GMT]]
Body: {"message":"success"}

Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ezilber-akamai
Copy link
Contributor Author

Nice work!

Thanks for the review!

@ezilber-akamai ezilber-akamai merged commit 8f07a76 into linode:main Aug 2, 2024
4 checks passed
@ezilber-akamai ezilber-akamai deleted the TPT-2964-new-logging-system branch August 2, 2024 15:15
@ezilber-akamai ezilber-akamai added the improvement for improvements in existing functionality in the changelog. label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants