Skip to content

Commit

Permalink
fix: [M3-9032] - ARIA label of action menu in Domains Landing table r…
Browse files Browse the repository at this point in the history
…ow (#11437)

* Fix action menu aria-label

* Added changeset: ARIA label of action menu in Domains Landing table row

* Update e2e tests
  • Loading branch information
pmakode-akamai authored Dec 19, 2024
1 parent fff1b6c commit 2867d82
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 5 deletions.
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-11437-fixed-1734527875368.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Fixed
---

ARIA label of action menu in Domains Landing table row ([#11437](https://github.com/linode/manager/pull/11437))
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ describe('Clone a Domain', () => {
.closest('tr')
.within(() => {
ui.actionMenu
.findByTitle(`Action menu for Domain ${domain}`)
.findByTitle(`Action menu for Domain ${domain.domain}`)
.should('be.visible')
.click();
});
Expand All @@ -84,7 +84,7 @@ describe('Clone a Domain', () => {
.closest('tr')
.within(() => {
ui.actionMenu
.findByTitle(`Action menu for Domain ${domain}`)
.findByTitle(`Action menu for Domain ${domain.domain}`)
.should('be.visible')
.click();
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('Delete a Domain', () => {
.closest('tr')
.within(() => {
ui.actionMenu
.findByTitle(`Action menu for Domain ${domain}`)
.findByTitle(`Action menu for Domain ${domain.domain}`)
.should('be.visible')
.click();
});
Expand All @@ -57,7 +57,7 @@ describe('Delete a Domain', () => {
.closest('tr')
.within(() => {
ui.actionMenu
.findByTitle(`Action menu for Domain ${domain}`)
.findByTitle(`Action menu for Domain ${domain.domain}`)
.should('be.visible')
.click();
});
Expand Down
2 changes: 1 addition & 1 deletion packages/manager/src/features/Domains/DomainActionMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export const DomainActionMenu = React.memo((props: DomainActionMenuProps) => {
})}
<ActionMenu
actionsList={menuActions}
ariaLabel={`Action menu for Domain ${domain}`}
ariaLabel={`Action menu for Domain ${domain.domain}`}
/>
</>
);
Expand Down

0 comments on commit 2867d82

Please sign in to comment.