clean up constants

packages/manager/src/features/NodeBalancers/NodeBalancerConfigPanel.test.tsx

@@ -3,12 +3,8 @@ import * as React from 'react';
 
 import { renderWithTheme } from 'src/utilities/testHelpers';
 
+import { ALGORITHM_HELPER_TEXT } from './constants';
 import { NodeBalancerConfigPanel } from './NodeBalancerConfigPanel';
-import {
-  LEAST_CONNECTIONS_ALGORITHM_HELPER_TEXT,
-  ROUND_ROBIN_ALGORITHM_HELPER_TEXT,
-  SOURCE_ALGORITHM_HELPER_TEXT,
-} from './utils';
 
 import type {
   NodeBalancerConfigNodeFields,
@@ -225,11 +221,15 @@ describe('NodeBalancerConfigPanel', () => {
       <NodeBalancerConfigPanel {...nbConfigPanelMockPropsForTest} />
     );
 
-    expect(getByText(ROUND_ROBIN_ALGORITHM_HELPER_TEXT)).toBeVisible();
+    expect(getByText(ALGORITHM_HELPER_TEXT.roundrobin)).toBeVisible();
+
+    expect(queryByText(ALGORITHM_HELPER_TEXT.source)).not.toBeInTheDocument();
+    expect(
+      queryByText(ALGORITHM_HELPER_TEXT.leastconn)
+    ).not.toBeInTheDocument();
     expect(
-      queryByText(LEAST_CONNECTIONS_ALGORITHM_HELPER_TEXT)
+      queryByText(ALGORITHM_HELPER_TEXT.ring_hash)
     ).not.toBeInTheDocument();
-    expect(queryByText(SOURCE_ALGORITHM_HELPER_TEXT)).not.toBeInTheDocument();
   });
 
   it('renders the relevant helper text for the Least Connections algorithm', () => {
@@ -240,10 +240,14 @@ describe('NodeBalancerConfigPanel', () => {
       />
     );
 
-    expect(getByText(LEAST_CONNECTIONS_ALGORITHM_HELPER_TEXT)).toBeVisible();
-    expect(queryByText(SOURCE_ALGORITHM_HELPER_TEXT)).not.toBeInTheDocument();
+    expect(getByText(ALGORITHM_HELPER_TEXT.leastconn)).toBeVisible();
+
+    expect(queryByText(ALGORITHM_HELPER_TEXT.source)).not.toBeInTheDocument();
     expect(
-      queryByText(ROUND_ROBIN_ALGORITHM_HELPER_TEXT)
+      queryByText(ALGORITHM_HELPER_TEXT.ring_hash)
+    ).not.toBeInTheDocument();
+    expect(
+      queryByText(ALGORITHM_HELPER_TEXT.roundrobin)
     ).not.toBeInTheDocument();
   });
 
@@ -255,12 +259,16 @@ describe('NodeBalancerConfigPanel', () => {
       />
     );
 
-    expect(getByText(SOURCE_ALGORITHM_HELPER_TEXT)).toBeVisible();
+    expect(getByText(ALGORITHM_HELPER_TEXT.source)).toBeVisible();
+
+    expect(
+      queryByText(ALGORITHM_HELPER_TEXT.leastconn)
+    ).not.toBeInTheDocument();
     expect(
-      queryByText(ROUND_ROBIN_ALGORITHM_HELPER_TEXT)
+      queryByText(ALGORITHM_HELPER_TEXT.ring_hash)
     ).not.toBeInTheDocument();
     expect(
-      queryByText(LEAST_CONNECTIONS_ALGORITHM_HELPER_TEXT)
+      queryByText(ALGORITHM_HELPER_TEXT.roundrobin)
     ).not.toBeInTheDocument();
   });
 

packages/manager/src/features/NodeBalancers/NodeBalancerConfigPanel.tsx

@@ -15,13 +15,11 @@ import { ActionsPanel } from 'src/components/ActionsPanel/ActionsPanel';
 import { Link } from 'src/components/Link';
 import { useFlags } from 'src/hooks/useFlags';
 
+import { ALGORITHM_HELPER_TEXT } from './constants';
 import { ActiveCheck } from './NodeBalancerActiveCheck';
 import { NodeBalancerConfigNode } from './NodeBalancerConfigNode';
 import { PassiveCheck } from './NodeBalancerPassiveCheck';
 import {
-  LEAST_CONNECTIONS_ALGORITHM_HELPER_TEXT,
-  ROUND_ROBIN_ALGORITHM_HELPER_TEXT,
-  SOURCE_ALGORITHM_HELPER_TEXT,
   getAlgorithmOptions,
   getStickinessOptions,
   setErrorMap,
@@ -192,13 +190,6 @@ export const NodeBalancerConfigPanel = (
     return eachAlg.value === algorithm;
   });
 
-  const algorithmHelperText = {
-    leastconn: LEAST_CONNECTIONS_ALGORITHM_HELPER_TEXT,
-    ring_hash: '', // @todo Add copy as part of UDP NodeBalancer project
-    roundrobin: ROUND_ROBIN_ALGORITHM_HELPER_TEXT,
-    source: SOURCE_ALGORITHM_HELPER_TEXT,
-  };
-
   const sessionOptions = getStickinessOptions(protocol);
 
   const defaultSession = sessionOptions.find((eachSession) => {
@@ -347,7 +338,7 @@ export const NodeBalancerConfigPanel = (
             size="small"
             value={defaultAlg || algOptions[0]}
           />
-          <FormHelperText>{algorithmHelperText[algorithm]}</FormHelperText>
+          <FormHelperText>{ALGORITHM_HELPER_TEXT[algorithm]}</FormHelperText>
         </Grid>
 
         <Grid md={3} xs={6}>

packages/manager/src/features/NodeBalancers/constants.ts

@@ -0,0 +1,14 @@
+const ROUND_ROBIN_ALGORITHM_HELPER_TEXT =
+  'Round robin distributes connection requests to backend servers in weighted circular order.';
+
+const LEAST_CONNECTIONS_ALGORITHM_HELPER_TEXT =
+  'Least connections assigns connections to the backend with the least connections.';
+
+const SOURCE_ALGORITHM_HELPER_TEXT = "Source uses the client's IPv4 address.";
+
+export const ALGORITHM_HELPER_TEXT = {
+  leastconn: LEAST_CONNECTIONS_ALGORITHM_HELPER_TEXT,
+  ring_hash: '', // @todo M3-9019 - Add copy as part of UDP NodeBalancer project
+  roundrobin: ROUND_ROBIN_ALGORITHM_HELPER_TEXT,
+  source: SOURCE_ALGORITHM_HELPER_TEXT,
+};

packages/manager/src/features/NodeBalancers/utils.ts

@@ -229,12 +229,3 @@ export const getStickinessOptions = (
     { label: 'HTTP Cookie', value: 'http_cookie' },
   ];
 };
-
-export const ROUND_ROBIN_ALGORITHM_HELPER_TEXT =
-  'Round robin distributes connection requests to backend servers in weighted circular order.';
-
-export const LEAST_CONNECTIONS_ALGORITHM_HELPER_TEXT =
-  'Least connections assigns connections to the backend with the least connections.';
-
-export const SOURCE_ALGORITHM_HELPER_TEXT =
-  "Source uses the client's IPv4 address.";